Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SG_quad out of cache #3462

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Move SG_quad out of cache #3462

merged 2 commits into from
Dec 13, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Dec 3, 2024

There is no reason for SG_quad to be in AtmosCache: it is constant and is firmly attached to a specific function.

Sbozzolo
Sbozzolo commented Dec 11, 2024
View reviewed changes
src/solver/types.jl Outdated
"""
AbstractCloudModel

Defines how to compute the cloud fraction
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Defines how to compute the cloud fraction
Defines how to compute the cloud fraction.

@Sbozzolo Sbozzolo requested a review from trontrytel December 11, 2024 00:51
@Sbozzolo Sbozzolo marked this pull request as ready for review December 11, 2024 00:51
@trontrytel
Copy link
Member

Seems like all the buildkite errors are because of

ERROR: LoadError:
--
  |  
  | Pull request author:
  | It seems that a new dataset,
  |  
  | dataset file:`diagnostic_edmfx_aquaplanet/output_0000/prog_state.nc`,
  | was created, or the name of the dataset
  | has changed. Please increment the reference
  | counter in `reproducibility_tests/ref_counter.jl`.
  |  
  | If this is not the case, then please
  | open an issue with a link pointing to this
  | PR and build.

not sure why though. We should not be changing anything about the file names in the output here.

Sbozzolo and others added 2 commits December 12, 2024 07:48
@Sbozzolo
Move SG_quad out of cache
01b4f27 
There is no reason for SG_quad to be in AtmosCache: it is constant and
is firmly attached to a specific function.
@trontrytel @Sbozzolo
Remove unused Lognormal quadrature type, add docstrings
3fed071
@Sbozzolo Sbozzolo enabled auto-merge December 12, 2024 15:48
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 2f1e73f Dec 13, 2024
16 checks passed
@Sbozzolo Sbozzolo deleted the gb/sg_cache branch December 13, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @trontrytel